Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tresor, kitkat, berghain #171

Merged
merged 5 commits into from
Mar 8, 2024
Merged

tresor, kitkat, berghain #171

merged 5 commits into from
Mar 8, 2024

Conversation

atvanguard
Copy link

Why this should be merged

A node can choose to run 1 of the 4 modes

  1. Validator only (tresor) - They only run our subnet binary, validate txs. They will not run the matching engine and/or maintain in-memory db. They can even choose to ignore the signed orders gossiped to them. Any number of them can be added to network.
  2. Validator + matching engine (kitkat) - Runs the matching engine and maintains in-memory db. Any updates to matching engine will only be pushed to these nodes.
  3. RPC nodes (berghain) - Maintains in-memory db to be able to serve APIs. Can be started in various geographies and a load-balancer on top of all of them.
  4. (kitkat_berghain) 2 + 3 for local testing

@atvanguard atvanguard requested a review from lumos42 March 7, 2024 10:30
debaghtk
debaghtk reviewed Mar 7, 2024
View reviewed changes
plugin/evm/vm.go Outdated Show resolved Hide resolved
debaghtk
debaghtk reviewed Mar 7, 2024
View reviewed changes
plugin/evm/order_api.go Outdated Show resolved Hide resolved
@debaghtk
Copy link
Collaborator

debaghtk commented Mar 7, 2024

couple tiny comments, LGTM otherwise

debaghtk
debaghtk reviewed Mar 7, 2024
View reviewed changes
plugin/evm/limit_order.go Outdated Show resolved Hide resolved
lumos42
lumos42 reviewed Mar 8, 2024
View reviewed changes
plugin/evm/vm.go Show resolved Hide resolved
plugin/evm/vm.go Outdated Show resolved Hide resolved
@atvanguard atvanguard merged commit 8f6e081 into aylin Mar 8, 2024
3 checks passed
@atvanguard atvanguard deleted the berlin-modes branch March 8, 2024 09:32
atvanguard added a commit that referenced this pull request Mar 11, 2024
@atvanguard
tresor, kitkat, berghain (#171)
35f9293 
* tresor, kitkat, berghain

* resolve debas comments

* chain config

* slight refactor

* resolve lumos comments
atvanguard added a commit that referenced this pull request Mar 15, 2024
@HugoBroudeur @atvanguard
feature/oonodz-integration. Integrate ooNodz workflow and create and …
34e14f5 
…push docker images (#176)

* tresor, kitkat, berghain (#171)

* tresor, kitkat, berghain

* resolve debas comments

* chain config

* slight refactor

* resolve lumos comments

* feature/oonodz-integration. Integrate ooNodz workflow and create and
push docker images

feature/oonodz-integration. Update variables

* feature/oonodz-integration. Also produce the aylin image for the mainnet

---------

Co-authored-by: atvanguard <[email protected]>
Co-authored-by: Hugo Broudeur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumos42 lumos42 lumos42 left review comments

@debaghtk debaghtk debaghtk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atvanguard @debaghtk @lumos42