Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add Hub Connection Functionality #15
[WIP] Add Hub Connection Functionality #15
Changes from 17 commits
9204b94
e8782c2
85c3167
091aa12
cadb440
5824273
0866c7f
c7b0a66
e69d999
73afb1b
914b813
0577ed7
da1077c
dae7498
d8541ae
c22c315
e2817ec
44ac1ac
1335e45
4497211
cec178e
ab81ae6
7a1fc39
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we don't want to subset to
model_tasks[[1]]
here. We may want to pull the values from allmodel_tasks
entries.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you clarify what you mean by:
In the currect hubmeta json files, the
model_tasks
element contains a list consisting of a single unnamed element which in turn contains two named list elements,task_ids
&output_types
(see below).Hence I'm using
[[1]]
to access the underlyingtask_ids
&output_types
. Perhaps this superfluous unnamed list element shouldn't be there?Created on 2022-10-24 with reprex v2.0.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually @elray1 ! I believe it is myself that has misunderstood here. When I was working on the JSON schema, I realised
"round-1"
in the complex example has two elements in model tasks! Hence your comment is absolutely valid.This needs a little more thought for how to handle so will work on it first thing next week.