Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Br v4.0.0 #103

Merged
merged 23 commits into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
527258f
Update new version branch naming instruction to use `br-` prefix
annakrystalli Oct 7, 2024
a813ebb
Create v4.0.0 directory
annakrystalli Oct 9, 2024
c25f08d
Add derived_task_ids property. Resolves #96
annakrystalli Oct 9, 2024
4d2e935
Disallow optional output type ids + introduce 'is_required' property.…
annakrystalli Oct 9, 2024
20d95d2
Add specifics about repository object. Resolves #98
annakrystalli Oct 9, 2024
2eb7a8e
Update NEWS
annakrystalli Oct 9, 2024
a0aa58e
Correct issue number
annakrystalli Oct 9, 2024
c3a61d7
Correct loaction example which should be array
annakrystalli Oct 9, 2024
65d91de
Fix indents with jq
annakrystalli Oct 9, 2024
938c6c2
merge main into br-v4.0.0
annakrystalli Oct 10, 2024
6bf0253
Fix typo
annakrystalli Oct 10, 2024
d29c9b8
Correct derived_task_ids location. Add round level derived_task_ids p…
annakrystalli Oct 11, 2024
9134635
Add round level derived_task_ids explanation
annakrystalli Oct 11, 2024
7c1fa0e
use additionalProperties to enforce target_keys properties are string…
annakrystalli Oct 16, 2024
392cfdc
Merge pull request #108 from hubverse-org/ak/target_keys-schema/97
annakrystalli Oct 16, 2024
bfabc6d
Encode point estimate output type IDs with null. Resolves #109
annakrystalli Oct 25, 2024
de81fd1
Update v4.0.0/tasks-schema.json
annakrystalli Oct 25, 2024
7543aa7
Update v4.0.0/tasks-schema.json
annakrystalli Oct 25, 2024
47beca8
Merge pull request #111 from hubverse-org/ak/null-point-estimate-outp…
annakrystalli Oct 25, 2024
1f42561
Set additionalProperties to false on lower level objects. Resolvse #114
annakrystalli Nov 1, 2024
1a4ee10
Remove 0 minimum value requirement for cdf numeric output type IDs. R…
annakrystalli Nov 1, 2024
bc23e4a
Update NEWS
annakrystalli Nov 1, 2024
6718e85
Merge pull request #115 from hubverse-org/ak/v4/additional-properties…
annakrystalli Nov 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
# v4.0.0

* BREAKING CHANGE: Introduction of `is_required` boolean property at the `output_type` level to configure whether the output type is required for submissions to be considered valid (#99).
* BREAKING CHANGE: Disallowed `optional` property in `output_type_id` objects. As such, when a given output type is submitted, values for all output type IDs much be submitted (#100,#101, #102).
* BREAKING CHANGE: To improve cross-platform interoperability, expectation of missing values in point estimate `output_type_id` `required` properties now encoded with `null` instead of `["NA"]` (#109).
* Introduction of optional `derived_task_ids` properties to enable hub administrators to define derived task IDs (i.e. task IDs whose values depend on the values of other task IDs). The higher level `derived_task_ids` property sets the property globally at the hub level but can be overriden by the round level `derived_task_ids` property. The property allows for primarily validation functionality to ignore such task IDs when appropriate which can significantly improve validation efficency (#96). For more information see [`hubValidations` documentation on ignoring derived task IDs](https://hubverse-org.github.io/hubValidations/articles/validate-pr.html#ignoring-derived-task-ids-to-improve-performance).
* Added more specific schema for `target_keys` to ensure only `string` properties are allowed (#97)
* Removed the requirement for a minimum value of zero in `cdf` numeric `output_type_id`s (#113).
* Ensured that additional properties are not allowed in lower level properties (e.g. individual task IDs, `output_type` objects etc). Custom additional properties are only allowed at the `round` level, while additional task ID objects that match the expected task ID schema are allowed in the `task_ids` object (#114).

# v3.0.1

* Introduction of optional `output_type_id_datatype` property to enable hub administrators to configure and communicate the `output_type_id` column data type at a hub level. This will allow hubs to override default behaviour of automatically determinining the simplest data type that can accomodate output type IDs across all output types when creating hub schema. The setting is also useful for administrators to future proof the `output_type_id` column from potential issues arising by changes in data type, introduced by new output types after submissions have begun, by setting `output_type_id_datatype` to the simplest data type from the start, i.e. character (#87).
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ After making a new release to the schema repository, ensure `hubDocs` are also a

## New schema version development process

- New schema versions should be developed in a separate branch. Name the branch `v{version-number}-branch` to avoid creating release tags which share the same name as a branch later on.
- New schema versions should be developed in a separate branch. Name the branch `br-v{version-number}` to avoid creating release tags which share the same name as a branch later on.
- New version branches should be merged into `main` when ready to released.
- Merging into `main` should be accompanied by creating an associated formal release in the repository.
- Re-run all tests in `hubAdmin`, address any introduced problems and update snapshots to latest schema version.
Expand Down
Loading
Loading