Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add read all permissions to diff commenter #104

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

zkamvar
Copy link
Member

@zkamvar zkamvar commented Oct 9, 2024

We were having trouble commenting the diff in #103 and have no clue why it's not working. Maybe this will fix it?

We were having trouble commenting the diff in #103 and have no clue why it's not working. Maybe this will fix it?
Copy link
Member

@annakrystalli annakrystalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure why not!

@annakrystalli
Copy link
Member

Does this need to be in #103 to work for it?

@zkamvar
Copy link
Member Author

zkamvar commented Oct 9, 2024

No, it just needs to be in main

@zkamvar zkamvar merged commit a99766c into main Oct 9, 2024
2 checks passed
@zkamvar zkamvar deleted the zkamvar-patch-1 branch October 9, 2024 14:35
@zkamvar
Copy link
Member Author

zkamvar commented Oct 9, 2024

No guarantee that it will work since it appeared to work before :/

@zkamvar
Copy link
Member Author

zkamvar commented Oct 9, 2024

/diff

@zkamvar
Copy link
Member Author

zkamvar commented Oct 9, 2024

okay no it doesn't work -_-

@annakrystalli
Copy link
Member

😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants