Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing diff commenter #105

Merged
merged 1 commit into from
Oct 9, 2024
Merged

testing diff commenter #105

merged 1 commit into from
Oct 9, 2024

Conversation

zkamvar
Copy link
Member

@zkamvar zkamvar commented Oct 9, 2024

I've added a block to dump the GitHub context so that maybe it will give some useful diagnostic about why that particular step was skipped.

@zkamvar zkamvar merged commit bed2a93 into main Oct 9, 2024
2 checks passed
@zkamvar zkamvar deleted the zkamvar-patch-1 branch October 9, 2024 16:19
@zkamvar
Copy link
Member Author

zkamvar commented Oct 9, 2024

/diff

1 similar comment
@zkamvar
Copy link
Member Author

zkamvar commented Oct 9, 2024

/diff

@zkamvar
Copy link
Member Author

zkamvar commented Oct 9, 2024

I FOUND THE REASON!

My first comment triggered this workflow: https://github.com/hubverse-org/schemas/actions/runs/11259016080/job/31306983330, and my status was not MEMBER as it says on my comment header, but rather: "author_association": "CONTRIBUTOR",

It turns out that Org membership has to be public for my author_association to be a MEMBER with the public API. So I went to https://github.com/orgs/hubverse-org/people and switched my visibility status to "public" (which I don't know why I didn't do that in the first place)

My second comment triggered this workflow run: https://github.com/hubverse-org/schemas/actions/runs/11259139890/job/31307395010, and now: "author_association": "MEMBER",

😩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants