Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TP + FSDPv2 / HSDP or just FSDPv2 / HSDP #3395

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kmehant
Copy link
Contributor

@kmehant kmehant commented Feb 13, 2025

What does this PR do?

  1. This PR proposes having FSDP2 as a separate distributed type for accelerate residing along with the FSDPv1 implementation.
  2. Furthermore, the PR also proposes use of prepare_nd_device_mesh util function to extend creation of device meshes for any combination of parallelisms. Currently it supports any combination of TP and FSDP/HSDP
  3. This PR should potentially supersede [RFC] Support FSDP2 #3231

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@SunMarc @muellerzr
@kwen2501 from PyTorch

Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant kmehant mentioned this pull request Feb 13, 2025
5 tasks
@kmehant kmehant mentioned this pull request Feb 27, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant