Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRANSLATION] Create Korean folder & toctree.yml #157

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

ahnjj
Copy link

@ahnjj ahnjj commented Feb 18, 2025

What does this PR do?

Create Korean folder for agent course and add toctree file.
Thank you in advance for your review.

Part of #148

Who can review?

Once the tests have passed, anyone in the community is welcome to review the PR.
You can also tag relevant members or contributors who might be interested.
@jeongiin, @harheem

@ahnjj ahnjj marked this pull request as draft February 18, 2025 00:59
@burtenshaw
Copy link
Collaborator

Thanks @ahnjj

I suggest that you translate units 0 and 1 into korean, and we will release that together. Is that ok for you?

@burtenshaw burtenshaw changed the title Create Korean folder & toctree.yml [TRANSLATION] Create Korean folder & toctree.yml Feb 18, 2025
@burtenshaw burtenshaw self-assigned this Feb 18, 2025
@ahnjj
Copy link
Author

ahnjj commented Feb 19, 2025

Thanks @ahnjj

I suggest that you translate units 0 and 1 into korean, and we will release that together. Is that ok for you?

I see! I will translate units 0 and 1 and create a new PR. Thanks for your reply!

@burtenshaw
Copy link
Collaborator

Hi @ahnjj and @harheem , what is the status of this?

@ahnjj
Copy link
Author

ahnjj commented Mar 4, 2025

Hi @ahnjj and @harheem , what is the status of this?

Hi! Thanks for checking in on us.

We’re currently working on Unit 1, having completed Unit 0.
We expect to finish it around this weekend.
Should we try to wrap it up quickly?

@ahnjj ahnjj marked this pull request as ready for review March 8, 2025 14:12
@ahnjj
Copy link
Author

ahnjj commented Mar 8, 2025

Hi @burtenshaw ! We've just completed unit 0&1 ! I would be appreciated if you check it :)

@ahnjj
Copy link
Author

ahnjj commented Mar 19, 2025

Hi @burtenshaw!
Sorry for rushing you on this.
I’d really appreciate it if you could check and help me push the merge!

@ahnjj ahnjj marked this pull request as draft March 21, 2025 00:38
@ahnjj ahnjj marked this pull request as ready for review March 21, 2025 00:38
Copy link
Collaborator

@burtenshaw burtenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structurally, this looks great. I'll just add the build workflows.

Copy link

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anchor가 빠진 부분이 있어 수정해보았습니다!

ahnjj and others added 5 commits March 29, 2025 00:25
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
@ahnjj
Copy link
Author

ahnjj commented Mar 28, 2025

Structurally, this looks great. I'll just add the build workflows.

Thank you! Seems only approval from maintainer left :) @burtenshaw

@ahnjj ahnjj requested a review from burtenshaw March 28, 2025 15:29
@ahnjj
Copy link
Author

ahnjj commented Mar 31, 2025

Hey @burtenshaw, I’d love to get this translation merged. Please let me know if there’s anything I should update! Appreciate your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants