Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fairseq to stable commit #135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bayartsogt-ya
Copy link

@bayartsogt-ya bayartsogt-ya commented Nov 3, 2022

Issue #134

Current version of fairseq is causing issues in STT pipeline so I changed it to the last commit of stable release of fairseq.

current: d47119871c2ac9a0a0aa2904dd8cfc1929b113d9
last: 59d966a92aabc68b6e0fe1f7bc3eeccbbbe91413

Error reproduce:
https://www.kaggle.com/code/bayartsogtya/notebooke77335cbe2/notebook
version 1 -> d471198
version 2 -> 59d966

link to huggingface failed example

@bayartsogt-ya
Copy link
Author

@osanseviero I wonder if there is any way to trigger automatic test in action from this fork?

@Narsil
Copy link
Contributor

Narsil commented Nov 3, 2022

@bayartsogt-ya , the test is run. It's the red one.

The current problem is that the docker takes too long to spawn for the test to pass (it's because the docker downloads a lot of files even on subsequent reloads).

If you want to test manually if it works for model facebook/mymodel you can do

./manage.py docker facebook/mymodel and send data through curl to see the output.

Does that help ?

@bayartsogt-ya
Copy link
Author

Here is a log of fairseq-docker build action:

Running script /app/prestart.sh
2022-11-03 16:43:55 | INFO | fairseq.tasks.text_to_speech | Please install tensorboardX: pip install tensorboardX
Traceback (most recent call last):
  File "app/main.py", line 7, in <module>
    from app.pipelines import Pipeline, SpeechToSpeechPipeline, TextToSpeechPipeline
  File "/app/app/pipelines/__init__.py", line 3, in <module>
    from app.pipelines.audio_to_audio import SpeechToSpeechPipeline
  File "/app/app/pipelines/audio_to_audio.py", line 12, in <module>
    from fairseq.models.speech_to_speech.hub_interface import S2SHubInterface
ModuleNotFoundError: No module named 'fairseq.models.speech_to_speech.hub_interface'

I cannot see fairseq.models.speech_to_speech.hub_interface was never a thing in fairseq for at least most recent stable tags...

@Narsil
Copy link
Contributor

Narsil commented Nov 3, 2022

I have no idea. Maybe git blame can help ?

It's possible it's an old relic of code when fairseq hub support was on a specific branch ?

@bayartsogt-ya
Copy link
Author

looks like changes were recent ones.
566caa5

@bayartsogt-ya
Copy link
Author

cc: @cndn
I think it is added to both api-inference-community and fairseq same day but somehow fairseq changes were reverted...
566caa5
facebookresearch/fairseq#4787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants