Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use python 3.9.18 instead of 3.9.15 #2090

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

severo
Copy link
Collaborator

@severo severo commented Nov 10, 2023

To upgrade on Ubuntu and pyenv, I had to do the following:

sudo apt install zlib1g zlib1g-dev libssl-dev libbz2-dev libsqlite3-dev
libncurses-dev libffi-dev liblzma-dev libreadline-dev graphviz
libgraphviz-dev
pyenv update
pyenv install 3.9.18

and in every project folder

poetry env use 3.9.18
poetry update python

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a6c727) 90.17% compared to head (1cee4e4) 90.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2090      +/-   ##
==========================================
- Coverage   90.17%   90.15%   -0.02%     
==========================================
  Files         261      261              
  Lines       15921    15921              
==========================================
- Hits        14356    14353       -3     
- Misses       1565     1568       +3     
Flag Coverage Δ
jobs_cache_maintenance 95.30% <ø> (ø)
jobs_mongodb_migration 86.69% <ø> (ø)
libs_libapi 83.37% <ø> (ø)
libs_libcommon 90.22% <ø> (-0.08%) ⬇️
services_admin 87.63% <ø> (ø)
services_api 87.09% <ø> (ø)
services_rows 85.49% <ø> (ø)
services_search 80.48% <ø> (ø)
services_sse-api 94.21% <ø> (ø)
services_worker 92.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 10, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was in my todo list. Thanks.

@severo
Copy link
Collaborator Author

severo commented Nov 10, 2023

[CI] 26 minutes (and counting) for the worker unit tests...

@severo
Copy link
Collaborator Author

severo commented Nov 10, 2023

I'll stop it and re-run

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this commit could be in a separate PR: 0f58abb

@severo
Copy link
Collaborator Author

severo commented Nov 10, 2023

OK. I'll just wait for #2089 to be merged, then rebase and redo the work here, so that we don't have to ignore the vulnerability

@albertvillanova
Copy link
Member

OK. I'll just wait for #2089 to be merged, then rebase and redo the work here, so that we don't have to ignore the vulnerability

Are we going to be merging PRs with red CI until that is fixed in datasets, released, and updated in datasets-server?

@severo
Copy link
Collaborator Author

severo commented Nov 10, 2023

#2089 has no red CI. We are disabling ArrayXD support for now from datasets-server

To upgrade on Ubuntu and pyenv, I had to do the following:

```
sudo apt install zlib1g zlib1g-dev libssl-dev libbz2-dev libsqlite3-dev
libncurses-dev libffi-dev liblzma-dev libreadline-dev graphviz
libgraphviz-dev
pyenv update
pyenv install 3.9.18
```

and in every project folder

```
poetry env use 3.9.18
poetry update python
```
@severo severo force-pushed the upgrade-minimal-python-version branch from 0f58abb to 1cee4e4 Compare November 10, 2023 13:48
@severo severo requested review from albertvillanova and a team November 10, 2023 13:55
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also update the DEVELOPER_GUIDE.

@severo
Copy link
Collaborator Author

severo commented Nov 10, 2023

Merging, so that we can create the following PRs on the right Python version, but not planning to deploy before Monday

@severo severo merged commit da54e3f into main Nov 10, 2023
23 checks passed
@severo severo deleted the upgrade-minimal-python-version branch November 10, 2023 16:32
pyenv install 3.9.15
pyenv local 3.9.15
pyenv install 3.9.18
pyenv local 3.9.18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I just saw it now...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think the developer guide is OK. There is no section for "update to a new version of python" but I'm not sure we need it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants