-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use python 3.9.18 instead of 3.9.15 #2090
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2090 +/- ##
==========================================
- Coverage 90.17% 90.15% -0.02%
==========================================
Files 261 261
Lines 15921 15921
==========================================
- Hits 14356 14353 -3
- Misses 1565 1568 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was in my todo list. Thanks.
[CI] 26 minutes (and counting) for the worker unit tests... |
I'll stop it and re-run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this commit could be in a separate PR: 0f58abb
OK. I'll just wait for #2089 to be merged, then rebase and redo the work here, so that we don't have to ignore the vulnerability |
Are we going to be merging PRs with red CI until that is fixed in |
#2089 has no red CI. We are disabling ArrayXD support for now from datasets-server |
To upgrade on Ubuntu and pyenv, I had to do the following: ``` sudo apt install zlib1g zlib1g-dev libssl-dev libbz2-dev libsqlite3-dev libncurses-dev libffi-dev liblzma-dev libreadline-dev graphviz libgraphviz-dev pyenv update pyenv install 3.9.18 ``` and in every project folder ``` poetry env use 3.9.18 poetry update python ```
0f58abb
to
1cee4e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also update the DEVELOPER_GUIDE
.
Merging, so that we can create the following PRs on the right Python version, but not planning to deploy before Monday |
pyenv install 3.9.15 | ||
pyenv local 3.9.15 | ||
pyenv install 3.9.18 | ||
pyenv local 3.9.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry! I just saw it now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think the developer guide is OK. There is no section for "update to a new version of python" but I'm not sure we need it
To upgrade on Ubuntu and pyenv, I had to do the following:
and in every project folder