add cacheable ParquetResponseEmptyError in first-rows-from-parquet #2101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1443
Currently, we have
{ _id: { cause: 'ParquetResponseEmptyError' }, count: 303 }
, records in cache collection with UnexpectedError because ofParquetResponseEmptyError
.Actually, we have two definitions of
ParquetResponseEmptyError
: one in parquet_utils.py https://github.com/huggingface/datasets-server/blob/main/libs/libcommon/src/libcommon/parquet_utils.py#L29 and another in https://github.com/huggingface/datasets-server/blob/main/libs/libcommon/src/libcommon/exceptions.py#L424.SplitFirstRowsFromParquetJobRunner
should throw the cacheable version ofParquetResponseEmptyError
but currently it is not handling the noncacheable exception leading to anUnexpectedError
.After this PR, I will refresh the cache of the 303 records.