Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Croissant] Update data field in new splits recordset #3087

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ccl-core
Copy link
Contributor

No description provided.

@ccl-core
Copy link
Contributor Author

@lhoestq @severo could you PTAL? Thanks!

@ccl-core
Copy link
Contributor Author

Follow-up to #3058

@lhoestq lhoestq merged commit 51817a4 into huggingface:main Oct 22, 2024
3 of 4 checks passed
@ccl-core
Copy link
Contributor Author

Thanks @lhoestq -- do you know how long it will take for this to be deployed more or less? I remember it took a few days for #3058, any chance we could speed the process up a bit for this PR?

@lhoestq
Copy link
Member

lhoestq commented Oct 22, 2024

I'm aiming for a deploy later today - will ping you once it's done

@lhoestq
Copy link
Member

lhoestq commented Oct 23, 2024

deployed ! :)

@ccl-core
Copy link
Contributor Author

Merciii!

@ccl-core
Copy link
Contributor Author

Hi @lhoestq ! We were wondering how long it might take before all datasets' croissants include this change?

We noticed that some of them, like e.g. https://huggingface.co/api/datasets/ai4bharat/sangraha/croissant, seem to still use split_name instead of split_record_set_name/split_name in the split recordset's "data" field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants