-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
squash refs/convert/... branch history after each series of commits #3131
Conversation
Sorry to bother @Wauplin: do you know why we cannot squash the refs/convert/{parquet,duckdb} branches yet on hub-ci? (see errors in the CI) |
cc @Pierrci @coyotte508 for that (dunno myself) What's sure is that squashing normal branches works correctly on hub-ci |
cc @Kakulukian it should be lmerged: https://github.com/huggingface-internal/moon-landing/pull/12253 |
API works fine on hub-ci maybe refs/convert/parquet needs to be urlencoded maybe not supported with the current method of hfh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ! feel free to merge once it's all good for you
I'll try to pass the tests, otherwise we will have the same issue in prod without a doubt. |
cc @hanouticelina maybe |
The error is:
|
=> indeed a url-encoding issue yes. Will fix that |
hmmm it was not an issue :) |
let's wait for the next hfh release, upgrade here, and we should be good |
Yep, sorry about the closing 😬
|
yes, thanks! I'm upgrading the deps |
…/convert/parquet|duckdb
Something strange, maybe related to #3092, @lhoestq while upgrading in webhook service. Could you have a special look at this part?
Plus: the operation in the git diff is the opposite:
|
OK, a lot of type errors, related to huggingface/huggingface_hub#2752 I guess. Not very important, but let's try to fix them here too |
Still failing. I made it work when using the repository user token, but it fails when using the bot user token. So: it's an issue in moon-landing: the bot should be able to squash refs/convert/... branches. I opened an issue: https://github.com/huggingface-internal/moon-landing/issues/12355 cc @coyotte508 @Kakulukian @Pierrci FYI (I could open a PR, but I don't feel super confident for auth-related stuff) |
PR open |
OK, the squash works. But we have another issue, possibly due to the hfh upgrade |
Happy to investigate if it's hfh-related but looks like a credential issue to me:
|
note that it needs to be an app token associated to a user (eg like the app token that pushes the commits to the parquet ref currently) |
OK, the 401 error was already present in a previous commit: https://github.com/huggingface/dataset-viewer/actions/runs/12828524481/job/36584381335. So... I think we can merge this one and then fix the issue with 401. Can it be linked with https://huggingface.slack.com/archives/C02EMARJ65P/p1738582122666929?thread_ts=1672852567.996239&cid=C02EMARJ65P (internal)? cc @lhoestq wdyt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure feel free to merge already, it should work directly once the issue is fixed
fixes #1774