Add deep link to Local Chat #1055
Conversation
DePasqualeOrg
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c,
pcuenca and
ngxson
as code owners
| mainTask: "text-generation", | ||
| displayOnModelPage: (model) => isMlxModel(model), | ||
| deeplink: (model) => | ||
| new URL(`https://localchat.co/model/${model.id}`), |
There was a problem hiding this comment.
| new URL(`https://localchat.co/model/${model.id}`), | |
| new URL(`localchat://model/${model.id}`), |
Shouldn't this be this? So that people get a directly deeplinked to the App?
There was a problem hiding this comment.
This route on localchat.co is a universal link that will open the model in app if the app is installed on the user's device. If the app is not installed, it will show a page with a link to download the app, which uses a "referral" search parameter to open the model in the app after it has been downloaded. And as a fallback, there is also a button on the page to open the model in the app if the app is installed.
|
btw do you have an SVG for the logo? :) |
|
I don't have an SVG, but you can find a PNG here. Would that work? |
There was a problem hiding this comment.
Cool contribution as usual, @DePasqualeOrg, thanks a lot! 🙌
|
I'd love to get this merged. Is there anything else I need to do on my end? |
Co-authored-by: Pedro Cuenca <[email protected]>
DePasqualeOrg
force-pushed
the
add-link-to-local-chat
branch
from
cba3c34 to
f5e6dbd
Compare
|
It's been over two months since I submitted this PR. I'm an active contributor to several MLX and Hugging Face repositories in addition to creating one of the first iOS and macOS apps to run MLX models. I'd love for users of Local Chat to be able to use this feature. Could we please move ahead with this? |
|
Hi @DePasqualeOrg - yes, we are looking into the next batch now, will get this merged ASAP! |
My macOS and iOS app Local Chat runs text generation models from the MLX Community. I've added the ability to deep link to models in the app.