Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing-private #2845

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixing-private #2845

wants to merge 4 commits into from

Conversation

arthrod
Copy link

@arthrod arthrod commented Feb 9, 2025

No description provided.

Copy link
Author

@arthrod arthrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because get_session doesn't accept "private=False" and interprets it as "private=True," we had a bug in which if we passed "private=False" it wouldn't work.

@arthrod
Copy link
Author

arthrod commented Feb 9, 2025

@coderabbitai review

@arthrod
Copy link
Author

arthrod commented Feb 9, 2025

Sorry, my stupid lint messed up.

@arthrod
Copy link
Author

arthrod commented Feb 9, 2025

@CodeRabbit review

@Wauplin
Copy link
Contributor

Wauplin commented Feb 10, 2025

Hi @arthrod, I'm sorry but it's very hard to review the PR. Could you remove all the linting issues ? And let me know which lines exactly have been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants