-
Notifications
You must be signed in to change notification settings - Fork 672
Improve error handling for invalid eval results in model cards #3000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's weird is that this is already validated on the server side IIRC
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@julien-c it seems it's not the case, because here for example : https://huggingface.co/nozomuteruyo14/Diff_LoRA/blob/main/README.md, EDIT: doesn't exist server-side, but users can add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggesting a change so that we definitely get rid of these messy errors 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! Thanks for iterating :)
When listing models with
list_models(cardData=True)
, some models have incorrectly formatted eval results which causes errors during iteration:This is flagged in #2894 and in this internal slack message.
This PR does two things:
eval_results
to ensure they'reEvalResult
objects.ignore_metadata_errors
is true, allows users to ignore metadata errors (this is the case when parsing card data inModelInfo
).