Accelerator Fix and Local Image Load Support #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
reviewed
Jul 17, 2023
finetune_instruct_pix2pix.py
Outdated
| @@ -1075,7 +1081,8 @@ def collate_fn(examples): | |||
| pipeline.set_progress_bar_config(disable=True) | |||
|
|
|||
| # run inference | |||
| original_image = download_image(args.val_image_url) | |||
| # original_image = download_image(args.val_image_url) | |||
| original_image = open_image(args.val_image_url) | |||
There was a problem hiding this comment.
This won't work if you pass an image URL. It will only work if you pass an image file path that is local in nature.
There was a problem hiding this comment.
Pushing a change for this one to accept both a URL or a local file path
sayakpaul
reviewed
Jul 17, 2023
sayakpaul
reviewed
Jul 20, 2023
Comment on lines
+438
to
+442
| if source.startswith('http'): | ||
| # Download image from URL | ||
| response = requests.get(source, stream=True) | ||
| response.raise_for_status() | ||
| image = PIL.Image.open(response.raw) |
There was a problem hiding this comment.
We can simply use load_image() from diffusers.utils for this.
sayakpaul
reviewed
Jul 20, 2023
| @@ -1075,7 +1082,7 @@ def collate_fn(examples): | |||
| pipeline.set_progress_bar_config(disable=True) | |||
|
|
|||
| # run inference | |||
| original_image = download_image(args.val_image_url) | |||
| load_image(args.val_image_url) | |||
There was a problem hiding this comment.
load_image() doesn't return anything and is neither a closure inside main() so, I am sure about the effectivity of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referring to issue #5