-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llama tests #157
base: main
Are you sure you want to change the base?
llama tests #157
Conversation
@@ -37,6 +37,7 @@ def __init__(self, config: ModelArgs): | |||
TensorParallelColumnLinear: self._parametrize_column_linear, | |||
TensorParallelRowLinear: self._parametrize_row_linear, | |||
TritonRMSNorm: self._parametrize_layer_norm, | |||
RMSNorm: self._parametrize_layer_norm, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the same for SpectralMupParametrizator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Left some changes
We can disable flash attention automatically for old hardware: import torch
def supports_flash_attention(device_id):
"""Check if a GPU supports FlashAttention."""
major, minor = torch.cuda.get_device_capability(device_id)
# Check if the GPU architecture is Ampere (SM 8.x) or newer (SM 9.0)
is_sm8x = major == 8 and minor >= 0
is_sm90 = major == 9 and minor == 0
return is_sm8x or is_sm90 |
Add end-to-end test for llama.