Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Useful scripts #2

Merged
merged 11 commits into from
Dec 13, 2023
Merged

Useful scripts #2

merged 11 commits into from
Dec 13, 2023

Conversation

NouamaneTazi
Copy link
Member

@NouamaneTazi NouamaneTazi commented Sep 29, 2023 •
edited
Loading

  • add train script
  • add generate script
  • add test_training.py to check correctness (by finetuning a llama 7b for 100 iterations) (python tests/trest_training.py)

@NouamaneTazi NouamaneTazi changed the base branch from main to nouamane/refactor October 2, 2023 08:47
@NouamaneTazi NouamaneTazi changed the title Nouamane/refactor 2 Useful scripts Oct 2, 2023
@NouamaneTazi NouamaneTazi marked this pull request as ready for review October 2, 2023 08:48
thomwolf
thomwolf approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@thomwolf thomwolf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one question: I like using the python configs more and more. Should we allow for both already now ? (could be done in a later PR)

@NouamaneTazi
Copy link
Member Author

yes added a todo!

@NouamaneTazi NouamaneTazi merged commit 804b70c into nouamane/refactor Dec 13, 2023
1 check passed
@NouamaneTazi NouamaneTazi mentioned this pull request Dec 13, 2023
Closed
xrsrke pushed a commit that referenced this pull request May 20, 2024
@yardenas
Merge pull request #2 from yardenas/fix-tp
9a0087f 
tp test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomwolf thomwolf thomwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NouamaneTazi @thomwolf