-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: easier environment setup; pin trl
, transformers
#199
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Yeshwanth N <[email protected]>
- deepspeed - liger_kernel - math-verify - torch - trl - vllm
trl
, transformers
, math-verify
trl
, transformers
cc @lewtun if you get a minute, thanks for reviews - setup big issue for lot of people |
Ah, the README got changed, I gotta fix merge conflicts... Would be good to maybe get a review first and let me know how we think we should do README. Do we want that to be the default experiment, the minimal reason one from #197, that |
No it doesn't fix the issues. Installing the latest main of trl solves the issue actually. |
How much do you wanna bet that if I make a docker image with cu121 Debian, it is stable on this branch? I tested a ton from a clean env. We should really do a docker image anyway. |
I'm sure it works. Actually to simplify here is the timeline: commit 1 (v0.14): works User that locally have commit 2 should pull the latest commit from main to fix the issue, not pin 0.14. Pinning 0.14 should work, but it's not what we want. |
Oh, OK. Do you want to junk this PR or do you want me to just update it to pin it to git at a certain commit? Let's at least pin it to a specific commit rather than just reference main HEAD since that always moves. The comments in For the ones down in that section, when |
trl
/transformers
versions pinned (thanks to @yeshsurya for the note):Includes
lighteval
/math-verify
version bump from #193.setup.sh
has been tested from cold start on clean Debian CUDA 12.1 with GRPO example, 8x H100. Easier to set up, prints out the example command for the user at the end, shorter README section.Please test and edit README as appropriate.