[Testing Github workflow] Updating workflows and makefile #214
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @lewtun |
lewtun
requested changes
Feb 7, 2025
Makefile
Outdated
| @@ -14,6 +14,8 @@ quality: | |||
| isort --check-only $(check_dirs) setup.py | |||
| flake8 --max-line-length 119 $(check_dirs) setup.py | |||
|
|
|||
| test: | |||
| pytest tests/ | |||
There was a problem hiding this comment.
nit for debugging failed runs:
Suggested change
| pytest tests/ | |
| pytest -sv tests/ |
.github/workflows/quality.yml
Outdated
There was a problem hiding this comment.
Could we rename this action to tests.yml please?
There was a problem hiding this comment.
Sorry, do you mean rename the filename or creating another for tests?
… easier debugging
|
re-pinging @lewtun |
qgallouedec
reviewed
Feb 10, 2025
src/open_r1/rewards.py
Outdated
| @@ -59,10 +59,10 @@ def format_reward(completions, **kwargs): | |||
| def reasoning_steps_reward(completions, **kwargs): | |||
| """Reward function that checks for clear step-by-step reasoning. | |||
There was a problem hiding this comment.
maybe this instead?
Suggested change
| """Reward function that checks for clear step-by-step reasoning. | |
| r"""Reward function that checks for clear step-by-step reasoning. |
There was a problem hiding this comment.
Yes, that's cleaner, thanks
zeenolife
commented
Feb 10, 2025
tests/test_rewards.py
Outdated
| self.assertEqual(reward_fn, 0) | ||
| completions = [[{"content": "test test test"}]] | ||
| rewards = reward_fn(completions) | ||
| self.assertEqual(rewards, [0.0]) |
There was a problem hiding this comment.
This test was failing, because it was comparing int to function. I guess this was the intention
qgallouedec
approved these changes
Feb 10, 2025
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding automated testing for CI pipeline