Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: reimplement vllm backend beam search using logprobs #293

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Feat: reimplement vllm backend beam search using logprobs #293

merged 2 commits into from
Nov 25, 2024

Conversation

vicoooo26
Copy link
Contributor

@vicoooo26 vicoooo26 commented Oct 24, 2024 •
edited
Loading

Vllm upstream changed beam search implementation. Corresponding updates should be made to get compatibility with the latest vllm.
Reimplement vllm backend beam search using logprobs according to huggingface transformers implementation

@IlyasMoutawwakil IlyasMoutawwakil added the vllm [CI] Requires and enables running all vLLM tests label Nov 22, 2024
@IlyasMoutawwakil IlyasMoutawwakil marked this pull request as ready for review November 25, 2024 14:13
@IlyasMoutawwakil IlyasMoutawwakil merged commit 1c20082 into huggingface:main Nov 25, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyasMoutawwakil IlyasMoutawwakil IlyasMoutawwakil left review comments

Assignees
No one assigned
Labels
vllm [CI] Requires and enables running all vLLM tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicoooo26 @IlyasMoutawwakil