-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable t5 in SD3 pipe testing and flux img2img and inpaint #1016
base: main
Are you sure you want to change the base?
Conversation
76f8010
to
dc51ee2
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After I run
optimum-cli export openvino -m katuni4ka/tiny-random-flux ./tmp
I don't see a model for text_encoder_3
. Based on PR description I would expect that it should be there. Am I getting something wrong?
if is_transformers_version(">=", "4.40.0"): | ||
SUPPORTED_ARCHITECTURES.append("stable-diffusion-3") | ||
SUPPORTED_ARCHITECTURES.append("flux") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is flux addition conditioned on transformers version and not on is_diffusers_version(">=", "0.31.0")
as above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
problem in optimum-intel gone not from diffusers version, in github actions there is division by transformers version, diffusers always used the latest. problem with models imports comes from saving text encoders that are part of transformers with upper version of tokenizers than supported in transformers < 4.40 as the result test will fail in precommit
@nikita-savelyevv flux does not have text_encoder_3, it is expected. there is no changes in model export part for text_encoder_3, only its ignoring removed in tests. During writing tests I found that compilation of small t5 model used in test sd3 model failed with segfault on compilation stage, but this issue does not appear in real big models, so I disable loading of this model in tests i(it is optional part of sd3 pipeline and model can work without it, just with small accuracy drop). Now in 2024.5 issue was fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at failed diffusion tests
4f1deda
to
fe100fc
Compare
What does this PR do?
Before submitting