Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests-openvino extra requirement #1059

Conversation

nikita-savelyevv
Copy link
Collaborator

@nikita-savelyevv nikita-savelyevv commented Dec 10, 2024

What does this PR do?

Changes

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Comment on lines +59 to +60
"datasets[audio]>=1.4.0",
"tbb",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing datasets[audio] leads to numba package also being installed. Because of this, tbb needs to be installed as well. This is because with numbda installed, but tbb not installed, the following error is raised inside INC:

ValueError: No threading layer could be loaded.
HINT:
Intel TBB is required, try:
$ conda/pip install tbb

After both numba and tbb are installed, INC starts to pack bits relying on these packages. For example: https://github.com/intel/neural-compressor/blob/master/neural_compressor/torch/algorithms/weight_only/modules.py#L456-L457

@IlyasMoutawwakil As we've agreed before, could you please invite somebody from INC side for a review?

@nikita-savelyevv nikita-savelyevv marked this pull request as ready for review December 10, 2024 15:03
@IlyasMoutawwakil
Copy link
Member

INC seems to work ! thanks for following up on this.

@IlyasMoutawwakil IlyasMoutawwakil merged commit f6b73d0 into huggingface:main Dec 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants