Reduce img size in dummy_inputs for FLUX #1070
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
mvafin
commented
Dec 17, 2024
| @@ -1804,8 +1804,9 @@ def __init__( | |||
| normalized_config: NormalizedVisionConfig, | |||
| batch_size: int = DEFAULT_DUMMY_SHAPES["batch_size"], | |||
| num_channels: int = DEFAULT_DUMMY_SHAPES["num_channels"], | |||
| width: int = DEFAULT_DUMMY_SHAPES["width"], | |||
| height: int = DEFAULT_DUMMY_SHAPES["height"], | |||
| width: int = DEFAULT_DUMMY_SHAPES["width"] // 4, | |||
There was a problem hiding this comment.
This unfortunately doesn't work as defaults are set in the optimum code and this will not change the behaviour
There was a problem hiding this comment.
oh ! damn, then it's gonna be problematic as we also don't want to divide user specified input shapes
There was a problem hiding this comment.
@echarlaix do you know where exactly we can change these values for a specific architecture like Flux ?
I thought dummy inputs generators will use the defaults in their signature by default unless a user passes input shapes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In addition to #1064 this change further reduce memory usage for FLUX conversion
Fixes # (issue)
Before submitting