-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test for transformers 4.36 #1072
Fix test for transformers 4.36 #1072
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@IlyasMoutawwakil or @echarlaix full and slow tests fail with
Could you look into that? |
This failing test is not related to this PR so won't block merging : this test needs an hf token and should be skipped when not provided : https://github.com/huggingface/optimum-intel/blob/32ceae1d019f6884db609bd1aa48918820ebca61/tests/openvino/test_modeling.py#L399C1-L399C99 will look into it |
An other tests seems to be failing coming with openvino nightly :
Not related to this PR (https://github.com/huggingface/optimum-intel/actions/runs/12345566645/job/34449846316) but wondering if someone from the openvino team can look into it @helena-intel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @helena-intel !
Thanks for the heads-up @echarlaix , I'll look into it! |
Instead of #1063
When fixing the test for 4.37 I tried with 4.36 and tests passed with that too, so we can support this a little longer.
Also added workflow_dispatch trigger to OpenVINO test. This makes it easier to test these kinds of changes in a branch in a fork. workflow_dispatch only works if it is also in main, so without having this in main you always have to add it to the main branch of your fork first. If there's a reason not to have it, I'll remove it.
@AlexKoff88