Add a note about data-aware mixed precision assignment #1075
+25
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Recently there appeared a confusion regarding when the
dataset
argument actually affects the resulting model. I've added some notes to help clarifying this.Namely, if users provide compression
ratio<1
and a dataset at the same time, according to NNCF data-aware mixed precision usingMAX_ACTIVATION_VARIANCE
criterion will be applied. https://github.com/openvinotoolkit/nncf/blob/develop/nncf/quantization/algorithms/weight_compression/algorithm.py#L96Otherwise, if no data-aware compression algorithm is selected,
dataset
argument is not used.Before submitting