Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin npm version for doc building #424

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Pin npm version for doc building #424

merged 1 commit into from
Sep 7, 2023

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Sep 7, 2023

cc @echarlaix, npm 10.0.0 released 7 days ago apparently breaks this step:

 ERR! code EBADENGINE
1.096 npm ERR! engine Unsupported engine
1.096 npm ERR! engine Not compatible with your version of node/npm: [email protected]
1.097 npm ERR! notsup Not compatible with your version of node/npm: [email protected]
1.097 npm ERR! notsup Required: {"node":"^18.17.0 || >=20.5.0"}
1.097 npm ERR! notsup Actual:   {"npm":"9.2.0"}
1.099 
1.099 npm ERR! A complete log of this run can be found in:
1.099 npm ERR!     /root/.npm/_logs/2023-09-07T08_57_22_510Z-debug-0.log

@fxmarty fxmarty requested a review from echarlaix September 7, 2023 13:01
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 7, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @fxmarty !!

@echarlaix echarlaix merged commit 375942f into main Sep 7, 2023
10 of 11 checks passed
@echarlaix echarlaix deleted the fix-npm-dockerfile branch September 7, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants