Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openvino main export #439

Merged
merged 6 commits into from
Sep 29, 2023
Merged

Fix openvino main export #439

merged 6 commits into from
Sep 29, 2023

Conversation

echarlaix
Copy link
Collaborator

@echarlaix echarlaix commented Sep 27, 2023

Fix main_export for decoder models (which were exported twice : with /without past) as well as the resulting model file name which where wrongfully set for single models (SD and encoder/decoder models were not concerned). Also now the different OVModelForXxx classes all use main_export to export the model when needed

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 27, 2023

The documentation is not available anymore as the PR was closed or merged.

@helena-intel
Copy link
Collaborator

Thanks Ella! I noticed one issue with CausalLM export: when loading the model, I got the error "use_cachewas set toTruebut the loaded model only supportsuse_cache=False". During export I saw Overriding 2 configuration item(s) - use_cache -> True but it appears the model is exported without cache.

@echarlaix
Copy link
Collaborator Author

Thanks Ella! I noticed one issue with CausalLM export: when loading the model, I got the error "use_cachewas set toTruebut the loaded model only supportsuse_cache=False". During export I saw Overriding 2 configuration item(s) - use_cache -> True but it appears the model is exported without cache.

Thanks a lot for reporting it @helena-intel, could you share a code snippet for me to reproduce this ?

@echarlaix
Copy link
Collaborator Author

cc @eaidova

@helena-intel
Copy link
Collaborator

Thanks a lot for reporting it @helena-intel, could you share a code snippet for me to reproduce this ?

When I tried to reproduce it it did not occur, so I suppose it was a strange thing in my environment. Sorry for the false alarm!

@echarlaix
Copy link
Collaborator Author

When I tried to reproduce it it did not occur, so I suppose it was a strange thing in my environment. Sorry for the false alarm!

Thanks a lot for checking @helena-intel

@echarlaix echarlaix merged commit 72f369c into main Sep 29, 2023
12 checks passed
@echarlaix echarlaix deleted the fix-main-export branch September 29, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants