Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the logic of default 8-bit weights compression #445

Merged
merged 10 commits into from
Oct 4, 2023
Merged

Changed the logic of default 8-bit weights compression #445

merged 10 commits into from
Oct 4, 2023

Conversation

AlexKoff88
Copy link
Collaborator

@AlexKoff88 AlexKoff88 commented Oct 3, 2023 •
edited
Loading

@eaidova highlighted the case when load_in_8bits = False is passed explicitly. Based on this I revised the whole logic. Now,

  • warning is shown if nncf is absent in the text-generation branch
  • exception is raised everytime when load_in_8bits = True is passed without nncf
  • added tests

@AlexKoff88 AlexKoff88 requested a review from echarlaix October 3, 2023 13:39
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 3, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

echarlaix
echarlaix approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AlexKoff88 !

tests/openvino/test_training.py
expected_int8=31,
expected_int8=30,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change ?

@echarlaix echarlaix merged commit d761009 into main Oct 4, 2023
12 checks passed
@echarlaix echarlaix deleted the ak/8bit_default_comperssion branch October 4, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarlaix echarlaix echarlaix approved these changes

@eaidova eaidova eaidova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexKoff88 @HuggingFaceDocBuilderDev @eaidova @echarlaix