-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed transformers version conflict and fixed UT error #483
Closed
PenghuiCheng
wants to merge
7
commits into
huggingface:main
from
PenghuiCheng:penghuic/fixed_UT_error
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
edf5c97
Fixed install error for transformers
PenghuiCheng 087b880
Fixed UT error
PenghuiCheng 0d51d64
Fixed UT error
PenghuiCheng 2e48edc
Merge remote-tracking branch 'upstream/main' into penghuic/fixed_UT_e…
PenghuiCheng b64eaa5
Update UT code
PenghuiCheng 816c2cb
Fixed UT error
PenghuiCheng bdf535a
move 'intel-extension-for-pytorch' to be optional
PenghuiCheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this modification ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is error in test_quantize_text_generate_model UT with "hf-internal-testing/tiny-random-BloomForCausalLM" :
2023-12-19 11:14:01 [ERROR] Unexpected exception RuntimeError('INDICES element is out of DATA bounds, id=6168 axis_dim=1024') happened during tunin
g.
Traceback (most recent call last):
File "/home/penghuic/inc_pr/neural_compressor/quantization.py", line 234, in fit
strategy.traverse()
File "/home/penghuic/inc_pr/neural_compressor/strategy/auto.py", line 140, in traverse
super().traverse()
File "/home/penghuic/inc_pr/neural_compressor/strategy/strategy.py", line 504, in traverse
q_model = self.adaptor.quantize(copy.deepcopy(tune_cfg), self.model, self.calib_dataloader, self.q_func)
File "/home/penghuic/inc_pr/neural_compressor/utils/utility.py", line 304, in fi
res = func(*args, **kwargs)
File "/home/penghuic/inc_pr/neural_compressor/adaptor/pytorch.py", line 3630, in quantize
q_func(q_model._model)
File "/home/penghuic/optimum-intel-new/tests/neural_compressor/test_optimization.py", line 368, in calibration_fn
tmp_model.generate(**tokens, max_new_tokens=32, do_sample=False)
File "/home/penghuic/anaconda3/envs/py3.10/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your answer @PenghuiCheng, could you let me know in which case this issue is appearing and if yes what is causing it? I don't see it in the current CI, is this appearing when installing
neural-compressor
from source ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any news on this @PenghuiCheng ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Ella, Yes, This issue does not exist, it seems that my model has not been fully downloaded. I will close it. thanks!