Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix causallm weights compression via quantizaer #484

Merged

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Dec 6, 2023

What does this PR do?

this PR prevent issue with NotImplementedError: NNCF is not yet supported OpenVINO data type: bf16 on some platforms.
bf16 injected using preprocessing for modifying past key values precision based on inference precision hint applied before model compilation

@eaidova
Copy link
Collaborator Author

eaidova commented Dec 6, 2023

@echarlaix @AlexKoff88 @helena-intel could you please take a look

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@AlexKoff88 AlexKoff88 requested a review from echarlaix December 6, 2023 07:37
@canyurt7
Copy link

Hi

using latest OpenVino, I run into same issue with openvinotoolkit/openvino_notebooks#1514

Llama3 8B inference on CPU with OpenVino Optimum.

I see merge is there and I should not have run into the issue if it was fixed?

@AlexKoff88
Copy link
Collaborator

Hi @canyurt7, the fix is in progress in NNCF and OpenVINO but as a workaround you can cast model to float or float16 before optimizing it with OpenVINO/NNCF.

@helena-intel
Copy link
Collaborator

helena-intel commented Apr 23, 2024

Hi @canyurt7, when using optimum-intel with weight compression, you should not run into this issue. I have tested Llama-3-8B on 5th generation Xeon (with AMX/BF16). It's worth trying to update all your dependencies: pip install --upgrade --upgrade-strategy eager "optimum-intel[openvino]"@git+https://github.com/huggingface/optimum-intel.git and OpenVINO to the latest nightly version: pip install --upgrade --pre openvino --extra-index-url https://storage.openvinotoolkit.org/simple/wheels/nightly.

If that does not help, can you give some more information about what goes wrong and if possible post the output of the command/code you're running?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants