Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline #501

Merged
merged 37 commits into from
May 15, 2024
Merged

Pipeline #501

merged 37 commits into from
May 15, 2024

Conversation

jiqing-feng
Copy link
Collaborator

Hi @echarlaix . I just recognized that we didn't have any ipex optimization guide in README.

To make it more friendly to users, I integrated the generation modeling in our new pipeline. Users can just import pipeline from optimum-intel and easily apply optimum-intel optimization by only changing 1 line code from HF.

I think this approach is better than the old one, and it also aligns with optimum-nvidia

You can see that I simplified the pipeline as much as possible because we only need to consider text-generation for now. With this framework, it would be better to enable other tasks in the future.

Would you please help to review these changes? Thx!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@jiqing-feng
Copy link
Collaborator Author

Hi @echarlaix
I have updated the pipeline design to try to align with the optimum. Please take a look and check if the design is correct. Once our design is done, we could discuss the tests : )

tests/pipelines/test_pipelines.py Outdated Show resolved Hide resolved
optimum/intel/pipelines/__init__.py Show resolved Hide resolved
optimum/intel/pipelines/__init__.py Outdated Show resolved Hide resolved
tests/pipelines/test_pipelines.py Outdated Show resolved Hide resolved
@jiqing-feng
Copy link
Collaborator Author

Hi @echarlaix . Would you please review my changes? Thx!

Copy link
Member

@IlyasMoutawwakil IlyasMoutawwakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I left two comments about the usage of model_kwargs and hub_kwargs

@jiqing-feng
Copy link
Collaborator Author

Hi @IlyasMoutawwakil . Thanks for your review. Would you please check my new changes? Thx!

@jiqing-feng
Copy link
Collaborator Author

jiqing-feng commented Apr 29, 2024

Hi @IlyasMoutawwakil . I think we could merge this PR since the failed CIs are not related to my changes

optimum/intel/ipex/modeling_base.py Outdated Show resolved Hide resolved
optimum/intel/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
optimum/intel/pipelines/pipeline_base.py Show resolved Hide resolved
optimum/intel/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
optimum/intel/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
optimum/intel/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
optimum/intel/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
optimum/intel/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
optimum/intel/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
optimum/intel/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
@echarlaix
Copy link
Collaborator

To fix the code style test you can do the following :

pip install .[quality]
make style

optimum/intel/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
optimum/intel/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
@jiqing-feng
Copy link
Collaborator Author

Hi @echarlaix . I have fixed all your comments except the model/graph check. Would you please review it? Thx!

optimum/intel/ipex/modeling_base.py Outdated Show resolved Hide resolved
optimum/intel/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
optimum/intel/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
optimum/intel/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
@jiqing-feng
Copy link
Collaborator Author

Hi @echarlaix @IlyasMoutawwakil . Thanks for your review. I suppose we can merge it.

@echarlaix echarlaix merged commit d9c8f9f into huggingface:main May 15, 2024
10 of 11 checks passed
@jiqing-feng jiqing-feng deleted the pipeline branch October 9, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants