-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline #501
Pipeline #501
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Hi @echarlaix |
Hi @echarlaix . Would you please review my changes? Thx! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I left two comments about the usage of model_kwargs
and hub_kwargs
Hi @IlyasMoutawwakil . Thanks for your review. Would you please check my new changes? Thx! |
Hi @IlyasMoutawwakil . I think we could merge this PR since the failed CIs are not related to my changes |
To fix the code style test you can do the following :
|
Co-authored-by: Ella Charlaix <[email protected]>
Co-authored-by: Ella Charlaix <[email protected]>
Co-authored-by: Ella Charlaix <[email protected]>
Co-authored-by: Ella Charlaix <[email protected]>
Co-authored-by: Ella Charlaix <[email protected]>
Co-authored-by: Ella Charlaix <[email protected]>
Co-authored-by: Ella Charlaix <[email protected]>
Co-authored-by: Ella Charlaix <[email protected]>
Hi @echarlaix . I have fixed all your comments except the model/graph check. Would you please review it? Thx! |
Co-authored-by: Ella Charlaix <[email protected]>
Co-authored-by: Ella Charlaix <[email protected]>
Co-authored-by: Ella Charlaix <[email protected]>
Co-authored-by: Ella Charlaix <[email protected]>
Hi @echarlaix @IlyasMoutawwakil . Thanks for your review. I suppose we can merge it. |
Hi @echarlaix . I just recognized that we didn't have any ipex optimization guide in README.
To make it more friendly to users, I integrated the generation modeling in our new pipeline. Users can just import pipeline from optimum-intel and easily apply optimum-intel optimization by only changing 1 line code from HF.
I think this approach is better than the old one, and it also aligns with optimum-nvidia
You can see that I simplified the pipeline as much as possible because we only need to consider
text-generation
for now. With this framework, it would be better to enable other tasks in the future.Would you please help to review these changes? Thx!