Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openvino-nightly to automated tests #506

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

helena-intel
Copy link
Collaborator

Add openvino-nightly to automated tests (in addition to the openvino that is installed by setup.py).
We may not want to keep this for all the tests forever since it doubles the amount of tests on every PR - but for now it would be useful to check PRs with openvino-nightly before the OpenVINO 2023.0 release, and to catch any issues with openvino-nightly in existing code.
Also changed Python versions to test to 3.8 and 3.11.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@helena-intel helena-intel force-pushed the helena/test-openvino-nightly branch from acee0e5 to 52a5aae Compare January 9, 2024 10:50
@helena-intel helena-intel force-pushed the helena/test-openvino-nightly branch from 61a9fa6 to 1aafa43 Compare January 9, 2024 10:53
@@ -33,12 +34,9 @@ jobs:
# install PyTorch CPU version to avoid installing CUDA packages on GitHub runner without GPU
pip install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cpu
pip install .[openvino,nncf,tests,diffusers]
- name: Install openvino-nightly (optional)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It make sense to have tests with openvino-nightly, could make sense to add it in the nightly tests instead, wdyt ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@echarlaix I think that for now it would be useful to have it here, so we can test the PRs that target 2023.3. And then after 2023.3 we can move this to nightly tests?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the only issue is that the CI will be red until the next release (as the quantization tests will fail for one at least of the openvino version), will merge it anyway if that helps on your side!

@echarlaix echarlaix merged commit 2f2a764 into main Jan 16, 2024
11 of 13 checks passed
@echarlaix echarlaix deleted the helena/test-openvino-nightly branch January 16, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants