add token_type_ids in lm forward signature #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
eaidova
commented
Oct 28, 2024
eaidova
commented
Oct 28, 2024
eaidova
force-pushed
the
ea/add_token_type_ids
branch
from
070c681
to
43cca8f
Compare
echarlaix
reviewed
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
some tokenizers e.g. for https://huggingface.co/Qwen/Qwen-7B-Chat return token_type_ids output that does not used for this task, but bring some inconvenience with passing tokenizer provided output as is in model.generate (generate validates model inputs based on forward signature and failed with
ValueError: The following
model_kwargsare not used by the model: ['token_type_ids'] (note: typos in the generate arguments will also show up in this list)