Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix device selection for compilation language model in vlm and model saving #967

Merged
merged 13 commits into from
Nov 15, 2024
Merged

fix device selection for compilation language model in vlm and model saving #967

merged 13 commits into from
Nov 15, 2024

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Oct 24, 2024 •
edited
Loading

What does this PR do?

lefotovers for OVModelForVisulCausalLM

  • device changing in runtime with model.to()
  • compile only mode
  • downloading preconverted model from hub

all provided functionality converted by tests

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@eaidova eaidova changed the title fix device selection for compilation language model in vlm fix device selection for compilation language model in vlm and model saving Oct 24, 2024
echarlaix
echarlaix reviewed Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

optimum/intel/openvino/modeling_visual_language.py Outdated Show resolved Hide resolved
optimum/intel/openvino/modeling_visual_language.py Show resolved Hide resolved
optimum/intel/openvino/modeling_visual_language.py Outdated Show resolved Hide resolved
@eaidova eaidova force-pushed the ea/fix_device_assign_vlm branch 4 times, most recently from 42005a6 to 311737c Compare November 5, 2024 13:00
@eaidova eaidova mentioned this pull request Nov 8, 2024
Merged
3 tasks
@eaidova eaidova force-pushed the ea/fix_device_assign_vlm branch 3 times, most recently from 125360f to 82d0176 Compare November 13, 2024 16:01
@eaidova eaidova mentioned this pull request Nov 13, 2024
Merged
3 tasks
nikita-savelyevv
nikita-savelyevv reviewed Nov 14, 2024
View reviewed changes
optimum/intel/openvino/modeling_visual_language.py Outdated Show resolved Hide resolved
tests/openvino/test_modeling.py Outdated Show resolved Hide resolved
tests/openvino/test_modeling.py Outdated Show resolved Hide resolved
tests/openvino/test_modeling.py Outdated Show resolved Hide resolved
tests/openvino/test_modeling.py Outdated Show resolved Hide resolved
tests/openvino/test_modeling.py Outdated Show resolved Hide resolved
tests/openvino/test_modeling.py Outdated Show resolved Hide resolved
nikita-savelyevv
nikita-savelyevv approved these changes Nov 14, 2024
View reviewed changes
optimum/intel/openvino/modeling_visual_language.py Show resolved Hide resolved
tests/openvino/test_modeling.py Outdated Show resolved Hide resolved
tests/openvino/test_modeling.py Outdated Show resolved Hide resolved
@AlexKoff88 AlexKoff88 merged commit 040ee12 into huggingface:main Nov 15, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexKoff88 AlexKoff88 AlexKoff88 approved these changes

@nikita-savelyevv nikita-savelyevv nikita-savelyevv approved these changes

@IlyasMoutawwakil IlyasMoutawwakil Awaiting requested review from IlyasMoutawwakil

@echarlaix echarlaix Awaiting requested review from echarlaix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eaidova @HuggingFaceDocBuilderDev @nikita-savelyevv @AlexKoff88 @echarlaix