Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix order of hidden states in text encoder #984

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Oct 31, 2024

What does this PR do?

using sorting breaks topological order of outputs, it keeps output names in alphabetical order, that is different from topological if model has > 10 layers (e.g. hiden_states.0, hidden_states.1, ..., hidden_states.9, hidden_states.10 we got hidden_states.0, hidden_tates.1, hidden_states.10, hidden_states.2, ...., hidden_states.9) that significantly impact model accuracy for sdxl.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@AlexKoff88 AlexKoff88 merged commit e5fb400 into huggingface:main Nov 1, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants