Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading safety checker in pipeline #986

Closed

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Nov 4, 2024

What does this PR do?

fixing broken tests for textual inversion due to incorrect safety checker imports

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@eaidova eaidova added the openvino-test Trigger OpenVINO slow tests label Nov 4, 2024
}

additional_submodels = ["image_encoder", "safety_checker"]
Copy link
Member

@IlyasMoutawwakil IlyasMoutawwakil Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't solves the issue as it will just ignore and not load the safety_checker for example.
I provide a fix based on how diffusers handle the case of library_name being a module in their pipelines module #975 (comment)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pk, thanks, than I can close my pr?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, let's try merging the other PR today, it should accelerate per-commit openvino CI back to ~20mins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openvino-test Trigger OpenVINO slow tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants