Added a fix for FP16 overflow issue on GPU/NPU #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
eaidova
reviewed
Nov 11, 2024
| compress_to_fp16 = ov_config is not None and ov_config.dtype == "fp16" | ||
| model = _add_version_info_to_model(model, library_name) | ||
|
|
||
| if hasattr(config, "runtime_options"): | ||
| model = _add_runtime_options_to_rt_info(model, config.runtime_options) |
There was a problem hiding this comment.
maybe better to provide runtime options as argument instead of config if it is needed only for providing these options here?
There was a problem hiding this comment.
I looked at the proposed option. It means that I will need to carry this additional argument throughout all the calls between export_models() and _save_model()
eaidova
approved these changes
Nov 11, 2024
eaidova
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.