fix(test): correct nightly tests with random sampling #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the random sampling has changed, some tests were now broken. It seems that when the seed is 0, the sampling gets really close to whatever the greedy search was doing. To avoid further issues, the seed has been set to something else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since the random sampling has changed, some tests were now broken. It seems that when the seed is 0, the sampling gets really close to whatever the greedy search was doing. To avoid further issues, the seed has been set to something else.
Note this has been validated with https://github.com/huggingface/optimum-tpu/actions/runs/11949379268/job/33308708427