⚙️ Refactor TGI Dockerfile to support Google-Cloud-Containers as a target #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengomucho
reviewed
Dec 10, 2024
baptistecolle
force-pushed
the
refactor-dockerfile-for-vertex
branch
from
791bde5 to
f7f4cc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR refactor the optimum-tpu dockerfile to also support Google-Cloud-Containers.
This removes the need to maintain to different but similar Dockerfile in optimum-tpu and huggingface/Google-Cloud-Containers repo
I tested the 3 docker image (normal, IE and GCC) with test requests to make sure everything is still working as expected