Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating mllama after strftime. #2993

Merged
merged 14 commits into from
Feb 7, 2025
Merged

Updating mllama after strftime. #2993

merged 14 commits into from
Feb 7, 2025

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Feb 5, 2025

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil Narsil marked this pull request as ready for review February 5, 2025 11:13
. ./.venv/bin/activate && \
pwd && \
text-generation-server --help
uv pip install -e ".[accelerate, compressed-tensors, peft, outlines]" --no-cache-dir
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if intended, but missing quantized here

Suggested change
uv pip install -e ".[accelerate, compressed-tensors, peft, outlines]" --no-cache-dir
uv pip install -e ".[accelerate, compressed-tensors, quantized, peft, outlines]" --no-cache-dir

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be quantize though :).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I added it in the previous PR inadvertently, this is what was on main before. I rolled back the locking for Intel pretty much.

@Narsil Narsil merged commit 4b8cda6 into main Feb 7, 2025
15 checks passed
@Narsil Narsil deleted the fixing_template branch February 7, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants