fix: replace secret store on id change

[mateuszjenek]

This PR resolves an issue preventing updates to the id of the secret store. Previously, providers attempted to modify the id field directly, which the API does not permit. The new behavior replaces the entire resource instead.

Example output:

$terraform apply
humanitec_secretstore.ss: Refreshing state... [id=saml-test-ss-1]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # humanitec_secretstore.ss must be replaced
-/+ resource "humanitec_secretstore" "ss" {
      ~ id      = "saml-test-ss-1" -> "saml-test-ss-2" # forces replacement
        # (2 unchanged attributes hidden)
    }

Plan: 1 to add, 0 to change, 1 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

humanitec_secretstore.ss: Destroying... [id=saml-test-ss-1]
humanitec_secretstore.ss: Destruction complete after 0s
humanitec_secretstore.ss: Creating...
humanitec_secretstore.ss: Creation complete after 0s [id=saml-test-ss-2]

Apply complete! Resources: 1 added, 0 changed, 1 destroyed.

[delca85]

Can we add some integration tests for this?

[mateuszjenek]

This isn't a modifier test per se, but I've added a test that changes the id and verifies that the new resource reflects the updated id

[delca85]

What I'd like to see if a proof that the old secret store has been deleted and the new one has the new id. The 1st check might require a Humanitec client to fetch api.