Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix roles ids for users #83

Merged
merged 4 commits into from
May 4, 2024
Merged

Fix roles ids for users #83

merged 4 commits into from
May 4, 2024

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented May 1, 2024

  • member in user
  • only deployer for env_type

Following up on #79

@mathieu-benoit mathieu-benoit marked this pull request as draft May 1, 2024 19:46
@mathieu-benoit mathieu-benoit marked this pull request as ready for review May 1, 2024 19:55
@mathieu-benoit
Copy link
Contributor Author

Ready for your review, thanks!

@mathieu-benoit
Copy link
Contributor Author

This CI is failing on Run make testacc:

=== RUN   TestAccResourceDefinition/S3_static_-_secrets
    resource_definition_resource_test.go:166: Step 1/3 error: Check failed: Check 2/2 error: humanitec_resource_definition.s3_test_with_secrets: Attribute 'driver_inputs.secret_refs' expected "{\"aws_access_key_id\":{\"ref\":\"orgs/***/resources/defs/s3-test-with-secrets/driver_secrets/aws_access_key_id/.value\",\"store\":\"humanitec\"},\"aws_secret_access_key\":{\"ref\":\"orgs/***/resources/defs/s3-test-with-secrets/driver_secrets/aws_secret_access_key/.value\",\"store\":\"humanitec\"}}", got "{\"aws_access_key_id\":{\"ref\":\"orgs/***/resources/defs/s3-test-with-secrets/driver_secrets/aws_access_key_id/.value\",\"store\":\"humanitec\",\"version\":\"1\"},\"aws_secret_access_key\":{\"ref\":\"orgs/***/resources/defs/s3-test-with-secrets/driver_secrets/aws_secret_access_key/.value\",\"store\":\"humanitec\",\"version\":\"1\"}}"
--- FAIL: TestAccResourceDefinition (36.90s)

Not sure it's related, right?

@johanneswuerbach johanneswuerbach merged commit 18b43d1 into main May 4, 2024
2 checks passed
@johanneswuerbach johanneswuerbach deleted the fix-role-id-formatting branch May 4, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants