fix: handle resources deleted outside TF provider #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delca85
requested review from
mateuszjenek,
dharsanb,
astromechza and
docktorrr
and removed request for
mateuszjenek
astromechza
reviewed
Aug 1, 2024
| @@ -142,6 +142,12 @@ func (r *ResourceResourceClass) Read(ctx context.Context, req resource.ReadReque | |||
| return | |||
| } | |||
|
|
|||
| if httpResp.StatusCode() == 404 { | |||
| resp.Diagnostics.AddWarning("Resource class not found", fmt.Sprintf("The resource class (%s) was deleted outside Terraform", data.ID.ValueString())) | |||
There was a problem hiding this comment.
nitpick: I wonder if we should rather just say "The resource class (%s) does not exist"?
How do we know the resource actually ever existed? espescially if someone is using terraform state importing to add a resource they created by hand?
There was a problem hiding this comment.
How do we know the resource actually ever existed?
The case here is that the resource is in the TF state but we can't read it because we don't find it anymore.
I think it would be helpful to see this message in that case, no?
astromechza
reviewed
Aug 1, 2024
astromechza
approved these changes
Aug 1, 2024
mateuszjenek
approved these changes
Aug 1, 2024
| @@ -46,6 +46,10 @@ func TestAccResourceApplicationDeletedOutManually(t *testing.T) { | |||
|
|
|||
| orgID := os.Getenv("HUMANITEC_ORG") | |||
| token := os.Getenv("HUMANITEC_TOKEN") | |||
| APIHost := os.Getenv("HUMANITEC_HOST") | |||
There was a problem hiding this comment.
Nit: variables should be lowercased
Suggested change
| APIHost := os.Getenv("HUMANITEC_HOST") | |
| apiHost := os.Getenv("HUMANITEC_HOST") |
There was a problem hiding this comment.
You are right, fixed it!
delca85
force-pushed
the
wal-10237-res-delete-outside-tf
branch
from
207ee74
to
1726d08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the provider able to handle deletion of resources outside TF.
Integration tests have been added where they were missing.