Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match pipes to workers #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Match pipes to workers #10

wants to merge 1 commit into from

Conversation

rmccue
Copy link
Member

@rmccue rmccue commented Feb 9, 2016

Rather than relying on stream_select() giving us the array back as associative, match which worker it is manually.

Fixes humanmade/Cavalcade#6.

Rather than relying on stream_select() giving us the array back as
associative, match which worker it is manually.
@rmccue
Copy link
Member Author

rmccue commented Feb 9, 2016

@Djelibeybi Can you try this branch and see if it fixes your issue please? :)

Also, are you using HHVM? Seems like this is facebook/hhvm#5120

@Djelibeybi
Copy link

I'll give this a whirl later today. I'm not running HHVM, just native PHP 5.4 that ships with CentOS 6. I also tried it with PHP 7.0 build by Remi for CentOS 6 and it had the same problem.

@Djelibeybi
Copy link

Still crashes with the following error:

Feb 10 14:37:08 joy-dvmh-web-01 php: PHP Notice:  Undefined offset: 0 in /opt/Cavalcade-Runner/lib/Runner.php on line 226
Feb 10 14:37:08 joy-dvmh-web-01 php: PHP Fatal error:  Call to a member function is_done() on a non-object in /opt/Cavalcade-Runner/lib/Runner.php on line 227

FYI, for version purposes:

# /usr/bin/php -v
PHP 5.3.3 (cli) (built: Jul  9 2015 17:39:00)
Copyright (c) 1997-2010 The PHP Group
Zend Engine v2.3.0, Copyright (c) 1998-2010 Zend Technologies

@joehoyle
Copy link
Member

I think the fatal might be related to #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants