Ensure next run time is in the future.

[peterwilsoncc]

When rescheduling a task, check the next run time is in the future to prevent the event from looping while it catches up to the current time.

[rmccue]

This is actually intentional; say you have a job run once a day and it increments a counter, you would want it to bring the counter up to the expected value, rather than skip the jobs you'd expected to run.

Likewise, if you have a job run at a specific time (say, midnight every day), then you want it to always run at that time, rather than moving around. Setting it dynamically means it shifts forward, so you'd eventually end up minutes or hours after you'd expect it to run.

[rmccue]

Whoop, didn't mean to close immediately.

[peterwilsoncc]

you would want it to bring the counter up to the expected value

I guess that makes sense. It's something we could bikeshed all day but I'm happy if you close the PR.

if you have a job run at a specific time (say, midnight every day), then you want it to always run at that time, rather than moving around.

I defaulted to the old next run + interval in an attempt to avoid the drift. The drift should only happen if the event runs longer than the interval or something like wp_schedule_event( 0, 'daily', 'cavalcade_daily' ); is used to register event.

[rmccue]

@peterwilsoncc I wonder if we could capture this in a CLI command instead; something like wp cavalcade job restart {id} --skip-backlog?

[peterwilsoncc]

@rmccue That works for me, I've created an issue on the Cavalcade repo to follow up. humanmade/Cavalcade#68