Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support alternative method of passing Presigned params #178

Merged
merged 11 commits into from
Feb 29, 2024
Merged

Support alternative method of passing Presigned params #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cd2e976
Support alternative method of passing Presigned params
joehoyle Feb 28, 2024
1e7da5d
Add env for tests
joehoyle Feb 28, 2024
2c8cfea
Set env vars
joehoyle Feb 28, 2024
515735d
Show env
joehoyle Feb 28, 2024
dab01d0
Forward env
joehoyle Feb 28, 2024
97c38e8
Fix vars
joehoyle Feb 28, 2024
ac05940
Add missing item
joehoyle Feb 28, 2024
c7db344
Update script
joehoyle Feb 28, 2024
be69efa
npx jest
joehoyle Feb 28, 2024
8a3a703
PR feedback
joehoyle Feb 29, 2024
36d08bf
Use Object.fromEntries()
joehoyle Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,10 @@ jobs:
with:
node-version: 18.x
- run: npm install
- run: npm run test
- run: npx jest
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
S3_BUCKET: ${{ vars.S3_BUCKET }}
S3_REGION: ${{ vars.S3_REGION }}

7 changes: 7 additions & 0 deletions global.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,12 @@ declare var awslambda: {
streamifyResponse: (
handler: StreamifyHandler
) => ( event: APIGatewayProxyEventV2, context: ResponseStream ) => void,
HttpResponseStream: {
from( response: ResponseStream, metadata: {
headers?: Record<string, string>,
statusCode?: number,
cookies?: string[],
} ): ResponseStream
}
};

Loading
Loading