fix: Move Command additional props to be declared directly in `Comm…

…andProps` type (#31) * fix: include additional CommandProps in types file
huntabyte · Nov 18, 2023 · fe60ae1 · fe60ae1
1 parent 28fe1a7
commit fe60ae1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/.changeset/bright-kangaroos-explode.md b/.changeset/bright-kangaroos-explode.md
@@ -0,0 +1,5 @@
+---
+'cmdk-sv': patch
+---
+
+fix: move Command additional props to types file
diff --git a/src/lib/cmdk/components/Command.svelte b/src/lib/cmdk/components/Command.svelte
@@ -8,10 +8,7 @@
 	import { createCommand } from '../command.js';
 	import type { CommandProps } from '../types.js';
 
-	type $$Props = CommandProps & {
-		onKeydown?: (e: KeyboardEvent) => void;
-		asChild?: boolean;
-	};
+	type $$Props = CommandProps;
 
 	export let label: $$Props['label'] = undefined;
 	export let shouldFilter: $$Props['shouldFilter'] = true;

diff --git a/src/lib/cmdk/types.ts b/src/lib/cmdk/types.ts
@@ -102,7 +102,10 @@ export type CommandProps = Expand<
 		ids?: Partial<CommandIds>;
 	}
 > &
-	HTMLDivAttributes;
+	HTMLDivAttributes & {
+		onKeydown?: (e: KeyboardEvent) => void;
+		asChild?: boolean;
+	};
 
 export type ListProps = {
 	/**