Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Maintain original list order when clearing search input #35

Merged
merged 8 commits into from
Nov 19, 2023
Merged

fix: Maintain original list order when clearing search input #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a13446b
Merge remote-tracking branch 'upstream/main'
Not-Jayden Nov 18, 2023
b373759
Merge remote-tracking branch 'upstream/main'
Not-Jayden Nov 18, 2023
1b3bec0
fix: maintain original order when clearing search value
Not-Jayden Nov 18, 2023
a0b6653
chore: add changeset
Not-Jayden Nov 18, 2023
e677983
chore: add empty line
Not-Jayden Nov 18, 2023
a2da544
Merge remote-tracking branch 'upstream/main'
Not-Jayden Nov 18, 2023
9766a7a
Merge branch 'main' into fix-input-reordering
Not-Jayden Nov 18, 2023
685467c
fix: move key up
Not-Jayden Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/brave-lions-argue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'cmdk-sv': patch
---

fix: maintain original list order when clearing search value
11 changes: 8 additions & 3 deletions src/lib/cmdk/components/CommandList.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
<script lang="ts">
import { isHTMLElement } from '$lib/internal/index.js';
import { getCtx } from '../command.js';
import { getCtx, getState } from '../command.js';
import type { ListProps } from '../types.js';

const { ids } = getCtx();
const state = getState();

type $$Props = ListProps;

Expand Down Expand Up @@ -56,11 +57,15 @@
</script>

{#if asChild}
<slot {list} {sizer} />
{#key $state.search === ''}
Copy link
Contributor Author

@Not-Jayden Not-Jayden Nov 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally had this wrapping the entire component but that was causing a flicker in animations, so I've instead duplicated it above the default slots.

I think there's a risk this will cause unwanted animations on the items inside the list though 😕

<slot {list} {sizer} />
{/key}
{:else}
<div {...listAttrs} bind:this={el} {...$$restProps}>
<div {...sizerAttrs} use:sizerAction>
<slot />
{#key $state.search === ''}
<slot />
{/key}
</div>
</div>
{/if}
Loading