Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import specifier in src/lib/cmdk/types.ts #46

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

rsweeneydev
Copy link
Contributor

@rsweeneydev rsweeneydev commented Jan 11, 2024

The import specifier references a folder, which isn't allowed in ESM.

$lib/internal

should be

$lib/internal/index.js

This is breaking type resolution and intellisense for all the components.

Copy link

changeset-bot bot commented Jan 11, 2024

🦋 Changeset detected

Latest commit: d5dc4f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
cmdk-sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-sv ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 5:37am

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@rsweeneydev
Copy link
Contributor Author

No, thank you for all the incredible work you've doing lately. It's super impressive. You're single handedly making it 100x better to build web applications in Svelte.

@huntabyte huntabyte merged commit 95dce0f into huntabyte:main Jan 11, 2024
3 checks passed
@huntabyte huntabyte changed the title Fix import specifier in src/lib/cmdk/types.ts fix: import specifier in src/lib/cmdk/types.ts Jan 11, 2024
@github-actions github-actions bot mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants